Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blueprint]: Clean Up Create and Edit Type Node Modal #2111

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[Blueprint]: Clean Up Create and Edit Type Node Modal #2111

merged 2 commits into from
Sep 12, 2024

Conversation

Shoaibdev7
Copy link
Contributor

@Shoaibdev7 Shoaibdev7 commented Sep 10, 2024 •
edited
Loading

Problem:

closes: #2109

Issue ticket number and link:

Evidence:

https://www.loom.com/share/58d5edc94a9d49f2984c09b2527442e8

Create Type Modal:

image

Edit Type Modal:

image

Acceptance Criteria

  • Ensure the Create Type and Edit Type labels are included.
  • Separate the modal and header according to Figma design.

@Shoaibdev7
Copy link
Contributor Author

Hi @tomsmith8, @Rassl, Please review this PR.

@Shoaibdev7 Shoaibdev7 force-pushed the clean-up-blue-print-modal branch 2 times, most recently from 5f83cf7 to e3f09fd Compare September 10, 2024 09:40
@Shoaibdev7
Copy link
Contributor Author

Hi @Rassl, Please review this PR.

@Rassl Rassl self-requested a review September 12, 2024 11:57
Rassl
Rassl approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rassl Rassl merged commit cceefcd into stakwork:master Sep 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rassl Rassl Rassl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Blueprint]: Clean Up Create New Node Type and Edit Node Modal
2 participants
@Shoaibdev7 @Rassl